dlsyscourse / hw3

1 stars 20 forks source link

The wrong comment in ndarray_bakcend_cuda.cu #9

Open lzymmm123 opened 1 year ago

lzymmm123 commented 1 year ago

In src/ ndarray_bakcend_cuda.cu file, The comment of the parameter 'strides' and 'offset' with the function CompactKernel and Compact is not consistency.

CompactKernel:

 *   strides: vector of strides of out array
 *   offset: offset of out array

Compact:

 * strides: strides of the *a* array (not out, which has compact strides)
 *  offset: offset of the *a* array (not out, which has zero offset, being compact)

I think the parameters strides and offsets all belong to the input array "a".