Closed AstrakhantsevaAA closed 6 months ago
Hey @AstrakhantsevaAA, thanks for your review! I have created two ticket for the generator here:
Did you create a ticket for the paginator in the main repo or should I do this too? And let me know if I overlooked anything that should get an additional ticket.
PS: Secrets toml is generated, maybe you used and older version of the generator.
@sh-rp Thank for tickets!
Did you create a ticket for the paginator in the main repo or should I do this too?
I didn't but I can do that.
And let me know if I overlooked anything
autogenerate gitignore file? our regular, with secret.toml and .duckdb
Could you also replace dashes "-" in source names, e.g. "chargebee-pipeline" to "chargebee_pipeline", I cannot import module with dashes in name. And add empty init.py in the "chargebee-pipeline" folder automatically
Could you also replace dashes "-" in source names, e.g. "chargebee-pipeline" to "chargebee_pipeline", I cannot import module with dashes in name. And add empty init.py in the "chargebee-pipeline" folder automatically this is coming with the next release
gitignore is now also created. and I check the secrets.toml has all the vars. if no auth is detected, it will still prepare a secrets toml with the right sections for later use.
Problems:
Auth was generated with username as a string, it should be a secret:
Funny fact: if I set username as a dlt secret, then dlt will take var ENV $USERNAME
Run pipeline: should be
"offset_param": "next_offset",
Total in items issue:
fixed with replacing in dlt.sources.helpers.rest_client.paginators.RangePaginator.update_state
full tracebacks you can find here https://www.notion.so/dlthub/Alena-Chargebee-e390697e31b44dd48b7afeee48096688?pvs=4
Highlights:
Notes:
I would make this INFO more readable, add punctuation for example: