search

dlt-hub / dlt

data load tool (dlt) is an open source Python library that makes data loading easy 🛠️
https://dlthub.com/docs
Apache License 2.0
2.3k stars 150 forks source link

Broken link in documentation: complex credential types #1751

Open boxydog opened 2 weeks ago

boxydog commented 2 weeks ago

Documentation description

In https://dlthub.com/docs/general-usage/credentials/setup/#credential-types it says

To learn more about which credential types are supported, visit the complex credential types page.

That link "complex_types" is broken.

Are you a dlt user?

Yes, I'm already a dlt user.

boxydog commented 2 weeks ago

Looks like the link is now https://dlthub.com/docs/general-usage/credentials/complex_types

VioletM commented 2 weeks ago

Hm, @boxydog could you please double check, because the link works for me

boxydog commented 2 weeks ago

This link opens "Page Not Found": https://dlthub.com/docs/general-usage/credentials/setup/complex_types

burnash commented 4 days ago

@boxydog thanks for reporting this. @VioletM the link is indeed broken as it links to https://dlthub.com/docs/general-usage/credentials/setup/complex_types and the correct URL is https://dlthub.com/docs/general-usage/credentials/complex_types

burnash commented 4 days ago

@boxydog @VioletM ok looks like you're both right: the link to complex_types is incorrect if you land on https://dlthub.com/docs/general-usage/credentials/setup/ (note the trailing slash). @boxydog I wonder how you were able to get to this URL? @VioletM most likely the fix to this is to explicitly make links relevant to the current directory with ./ prefix.

boxydog commented 4 days ago

My first post on this ticket describes exactly how I got to that link. I don't know how to describe it any better.

On Tue, Sep 10, 2024, 6:39 AM Anton Burnashev @.***> wrote:

@boxydog https://github.com/boxydog @VioletM https://github.com/VioletM ok looks like you're both right: the link to complex_types is incorrect if you land on https://dlthub.com/docs/general-usage/credentials/setup/ (note the trailing slash). @boxydog https://github.com/boxydog I wonder how you were able to get to this URL? @VioletM https://github.com/VioletM most likely the fix to this is to explicitly make links relevant to the current directory with ./ prefix.

— Reply to this email directly, view it on GitHub https://github.com/dlt-hub/dlt/issues/1751#issuecomment-2340822265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWIC7D6I66ZQMRBHA7GW5V3ZV3Y75AVCNFSM6AAAAABNGRDC4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQHAZDEMRWGU . You are receiving this because you were mentioned.Message ID: @.***>