search

dlt-hub / dlt

data load tool (dlt) is an open source Python library that makes data loading easy 🛠️
https://dlthub.com/docs
Apache License 2.0
2.38k stars 154 forks source link

Docs | Typo in truncate table on staging destination parameter #1799

Open lvallance opened 2 weeks ago

lvallance commented 2 weeks ago

I noticed a typo in the documentation:

https://github.com/dlt-hub/dlt/blob/6451bd7ad9f5e3e9eec69ec02699ac4c2f7693d5/docs/website/docs/dlt-ecosystem/staging.md?plain=1#L111

The correct name of the parameter seems to be: truncate_tables_on_staging_destination_before_load

https://github.com/dlt-hub/dlt/blob/6451bd7ad9f5e3e9eec69ec02699ac4c2f7693d5/dlt/destinations/impl/dummy/configuration.py#L37

I think the documentation should be updated, I spent quite some time trying the different configurations options to realize the name of the parameter was not correct in the documentation.

Thanks for this package it's great, improving its documentation will make more people use it I'm sure!