search

dlt-hub / dlt

data load tool (dlt) is an open source Python library that makes data loading easy 🛠️
https://dlthub.com/docs
Apache License 2.0
2.38k stars 154 forks source link

Fix/1849 Do Not Parse Ignored Empty Responses #1851

Closed TheOneTrueAnt closed 4 days ago

TheOneTrueAnt commented 1 week ago

Description

Simple fix to remove the call to response.json() when logging the execution of an "ignore" response action, instead calls response.text. Included a test based off of the existing one for ignoring 404 errors.

Related Issues

Additional Context

Message lines were moved into a single line to meet with linter requirements.

netlify[bot] commented 1 week ago

Deploy Preview for dlt-hub-docs canceled.

Name Link
Latest commit 95fabd77a03a63e42a2d6875df1124978c1803ec
Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66eddc1614ff4d0007d7ed87
burnash commented 1 week ago

@TheOneTrueAnt thanks for the issue and for the fix.

TheOneTrueAnt commented 1 week ago

I realised that I'd neglected to run the linter after writing the tests! Have tidied them up now!