search

dlt-hub / dlt

data load tool (dlt) is an open source Python library that makes data loading easy 🛠️
https://dlthub.com/docs
Apache License 2.0
2.65k stars 176 forks source link

Bug in duckdb credentials resolution #1885

Closed sh-rp closed 2 weeks ago

sh-rp commented 1 month ago

When using two pipeline instances with a duckdb destination, the credentials are not resolved the right way. This does not seem to be the case for other destinations.

p1 = dlt.pipeline("p1", destination=duckdb(credentials="./duck1.duckdb"))
p2 = dlt.pipeline("p2", destination=duckdb(credentials="./duck2.duckdb"))

# both below lines print "duckdb:////Volumes/dlthub/dlt/duck2.duckdb"
# but the first one should be duck1.duckdb
print(p1.destination_client().config.credentials)
print(p2.destination_client().config.credentials)
rudolfix commented 2 weeks ago

@sh-rp I cannot reproduce this. also on master branch. there's a wrong warning though so smth. is still wrong