dlt-hub / dlt

data load tool (dlt) is an open source Python library that makes data loading easy 🛠️
https://dlthub.com/docs
Apache License 2.0
2.65k stars 176 forks source link

Add core sources extras to requirements in `dlt init` #2028

Closed burnash closed 3 days ago

burnash commented 1 week ago

Implements #1794

Not sure if this is the best way to do it as there's a lot of implicit stuff and assumptions. Mostly this is to handle missing extra for the rest_api source.

The alternatives to reading package metadata are:

netlify[bot] commented 1 week ago

Deploy Preview for dlt-hub-docs canceled.

Name Link
Latest commit 9ad11ea6d9a0a678b5b52f42820356fe7183f095
Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6733bd7c20a0b00008425236
sh-rp commented 1 week ago

@burnash from what I can tell this approach makes sense. What I would do: extend the dlt init tests to check the created requirements files and also do a manual test with each core source just to be sure it actually works.

burnash commented 1 week ago

What I would do: extend the dlt init tests to check the created requirements files and also do a manual test with each core source just to be sure it actually works.

Thanks @sh-rp, test are in 31bb59c