search

dlt-hub / verified-sources

Contribute to dlt verified sources 🔥
https://dlthub.com/docs/walkthroughs/add-a-verified-source
Apache License 2.0
50 stars 40 forks source link

rest_api: use RESTClient class from the dlt core #435

Closed burnash closed 2 months ago

burnash commented 2 months ago
burnash commented 2 months ago

A question: we have the same mock REST API server for testing both in core and here?

@rudolfix yes, not sure how to handle this, I use it in both places.

burnash commented 2 months ago

A question: we have the same mock REST API server for testing both in core and here?

@rudolfix yes, not sure how to handle this, I use it in both places.

I think the easiest is to remove the mock rest API from the core. It's not as important there as here, where we test parent-child endpoints

burnash commented 2 months ago

@rudolfix, tracking the mocker here: https://github.com/dlt-hub/dlt/issues/1293