sql_database: Add flag to include views with reflected tables

dlt-hub / verified-sources

Contribute to dlt verified sources 🔥

https://dlthub.com/docs/walkthroughs/add-a-verified-source

Apache License 2.0

48 stars 38 forks source link

sql_database: Add flag to include views with reflected tables #468

Closed steinitzu closed 1 month ago

steinitzu commented 1 month ago

Tell us what you do here

Add flag include_views to sql_database source to enable reflecting views
Test for the flag
Test for sql_table works when the table name is a view
Test for sql_database always includes views when they're passed in table_names regardless of the include_views flag

Related Issues

Resolves #459

steinitzu commented 1 month ago

@steini so code looks good by why counts do not match in the tests? any duplicated keys that multiply rows on the JOINs

Ah I didn't run all the tests locally in sequence so I missed this. The test db is session scoped and there's another incremental test that runs before and inserts more rows but didn't update the expected row counts for the view.

Should run now.