dlt-hub / verified-sources

Contribute to dlt verified sources 🔥
https://dlthub.com/docs/walkthroughs/add-a-verified-source
Apache License 2.0
72 stars 50 forks source link

feat(github): add stargazers #483

Closed cybermaxs closed 5 months ago

cybermaxs commented 5 months ago

Tell us what you do here

Short description

This PR adds a new resource for github stargazers. It provides the github user info (login, url, avatar) and the starred_at for every repo. The data is fetched using graphql and the full history is available.

Related Issues

not related to any issue

Additional Context

cybermaxs commented 5 months ago

🤔 Should I include the repository url in the response ?

rudolfix commented 5 months ago

🤔 Should I include the repository url in the response ?

hmmm I think not. the request is for particular repository so we do not need to tell which repository it is for each item. users can add this info themselves using add_map on the stargazers resource

cybermaxs commented 5 months ago

this is good! I enabled CI for this PR and all tests are passing. there are some linting errors. ping me if you are able to run mypy (see Makefile). if not we can fix it as well!

thanks for contribution!

I'll take a look, but I don't think this is related to my changes

rudolfix commented 5 months ago

@cybermaxs you are right! I reran the CI and all is green now!