dlt-hub / verified-sources

Contribute to dlt verified sources 🔥
https://dlthub.com/docs/walkthroughs/add-a-verified-source
Apache License 2.0
72 stars 50 forks source link

rest_api: rename `json_response` paginator to `json_link` #513

Closed burnash closed 4 months ago

burnash commented 5 months ago

Description

Currently, in the rest_api there are two paginators which use URL of the next page to paginate the results: json_response and header_link. json_response uses the next key in the JSON response, while header_link uses the Link header of the response.

Proposal

To be more consistent with the naming, and better reflect the actual functionality, we should rename the json_response paginator to json_link.

Task

Related issues

https://github.com/dlt-hub/dlt/issues/1495