search

dlubal-software / RFEM_Python_Client

Python client (or high-level functions) for RFEM 6 using Web Services, SOAP and WSDL
https://dlubal-software.github.io/.github/
MIT License
71 stars 28 forks source link

BUG: Add psutil to dependencies in setup.py #305

Closed MaartenBW closed 1 year ago

MaartenBW commented 1 year ago

Describe the bug In the latest version of the python client, psutil added to the dependency check in dependencies.py. But in the package dependencies in setup.py, this package is not added. So whenever the package is installed fresh using pip, psutil is not installed. So this triggers the prompt to install missing dependencies. So please add psutil also to setup.py, so it is automatically installed.

In my opinion: dependencies should not be managed with custom code like this. PyPi/Pip offers excellent dependency management, so why include this code youself? With a manual prompt?

OndraMichal commented 1 year ago

Hi @MaartenBW, thank you for noticing this. It'll be corrected. Regarding PyPi dependency management. It could be good but only if we don't lose dependency check when running code directly from repo.

Sacek073 commented 1 year ago

This issue was fixed in commit https://github.com/Dlubal-Software/RFEM_Python_Client/commit/489e1420baecb680722d6f2380f7a855ddc55a1e