dlumbrer
commented
4 years ago LGTM, sorry for the late reply, I was unable to test it
Closed mejarrett closed 4 years ago
dlumbrer
commented
4 years ago LGTM, sorry for the late reply, I was unable to test it
Replace deprecated vis library Almende/vis is at end of life and also produced this bug visjs/vis-network is actively developed, uses the same API, and only needed to be imported
Fix "Top Values" selection for node/edge bucketing and sizing. We often have large data results being returned for aggregations (greater than the default 5000), and Math.min is being used to choose between the default 5000 or the maxCutMetricSize returned by our results. This results in 5000 being used as the top value for node/edge size, which makes any results above that appear to be equally sized. For example, using
Counton a Field likeSrcIPcould return IP addresses with 20,000, 10,000, and 5,000 hits in our data set, which would all be equally sized as large nodes. This PR switches Math.min to Math.max.Tagging @craig-cogdill as a collaborator