dlumbrer / kbn_network

Network Plugin for Kibana
https://dlumbrer.github.io/kbn_network/
Apache License 2.0
368 stars 96 forks source link

Support for kibana 7.6.X #83

Open pchakour opened 4 years ago

pchakour commented 4 years ago

Hello everyone :)

I make the migration of the plugin for kibana 7.6.X. Feel free to use it or not. This is the zip containing the patch : kbn_network_7.6.X.zip

The patch include:

To apply it, you have to :

ranayayas commented 4 years ago

Hi ,

tks for the patch. I try to implement it, however not sure if I do the right way. Is the clone etc is performed in home folder or kibana folder? Can you give example of the command being used especially for the yarn

Tks

pchakour commented 4 years ago

Hi,

you have to clone the repository in the plugins directory that you can found in the kibana folder. If the plugins directory doesn't exist, create it...

This is the list of command to do, inside the plugins directory:

ranayayas commented 4 years ago

It works, tks. In my case, I have to do yarn --ignore-engines install

maintain3r commented 4 years ago

Hi pchakour, I try to use it with Kibana 7.6.2 and Elastiflow 4-beta-1 and it fails. The patch proposed above works with only when kibana-7.6.2 + elastiflow-3.5.2. Thank you.

Malwar3Ninja commented 4 years ago

Any update on this? Is the updated version released for 7.6.2 ?

cpiment commented 4 years ago

This is the list of command to do, inside the plugins directory:

  • git clone https://github.com/dlumbrer/kbn_network.git
  • cd kbn_network
  • git checkout a4a1cdb
  • git am --signoff -k < PATCH_PATH
  • yarn install

Thanks for your patch! I tried it and almost got me there, but I had to modify the package.json to make it work in Kibana 7.6.2

$ git diff package.json
diff --git a/package.json b/package.json
index 7c3b64b..770c029 100644
--- a/package.json
+++ b/package.json
@@ -1,9 +1,6 @@
 {
   "name": "network_vis",
-  "version": "7.5.2",
-  "kibana": {
-    "version": "kibana"
-  },
+  "version": "7.6.2",
   "authors": [
     "David Moreno Lumbreras <dmorenolumb@gmail.com>"
   ],
@@ -17,7 +14,7 @@
     "randomcolor": "^0.5.0",
     "keycharm": "^0.2.0",
     "moment": "^2.24.0",
-    "vis-data": "^6.2.1",
+    "vis-data": "^6.5.1",
     "vis-util": "^1.1.8"
   }
 }

I removed the "kibana" node of the package.json and updated the vis-data version to 6.5.1. With this changes I did an npm install instead of yarn install and zipped the plugin and installed it with kibana-plugin install.

@dlumbrer do you want a PR with this changes? The patch of @pchakour and my changes to package.json

dlumbrer commented 4 years ago

@dlumbrer do you want a PR with this changes? The patch of @pchakour and my changes to package.json

That would be awesome! Please, submit a PR to the 7-dev branch

cpiment commented 4 years ago

Submitted #85