Feature/improve synthesize to file

j-ixcayau commented 4 months ago

Summary

This PR introduces an isFullPath parameter to the synthesizeToFile function, enabling more flexible handling of file paths based on business logic requirements.

Details

New Feature: Added an optional isFullPath parameter to synthesizeToFile.
Default Behavior: The isFullPath parameter defaults to false, ensuring backward compatibility with existing projects.
Use Case: This enhancement allows projects to handle file paths more effectively when specific business logic necessitates it.

Compatibility

The addition of isFullPath is non-disruptive. Existing implementations of synthesizeToFile will continue to function as expected without any modifications, due to the optional nature of the new parameter.

Testing

Verified that the synthesizeToFile function behaves correctly with and without the isFullPath parameter in various scenarios.

yunchiri commented 4 months ago

wow

QuentinCG commented 4 months ago

This is a must have.

Note that this is needed since commit https://github.com/dlutton/flutter_tts/commit/3cb449d69238f478fe4635ad3a195c10d55b7a5b broke the base behavior :(

If you have this issue and this pull request is not merged, you should use version 4.0.0 of the plugin !

flutter_tts: 4.0.0

I've seen this just before updating my app and plugin version... Most users using this plugin will have their base behavior broken when upgrading the plugin version because of the change of behavior of synthesizeToFile method not allowing full path by default...

=> This pull request will allow us to upgrade the plugin version but will not fix base behavior being broken by the commit of 4.0.1 :(

dlutton / flutter_tts