search

dluvian / Nozzle

A lightweight nostr client for Android
MIT License
34 stars 3 forks source link

Support for Amber #62

Open greenart7c3 opened 7 months ago

greenart7c3 commented 7 months ago

Do you have any plans to add support for amber?

https://github.com/greenart7c3/amber

dluvian commented 7 months ago

I'd like to add a third party signer but don't want to be restricted to just Amber. Is it possible to add Amber support without explicitly including com.greenart7c3.nostrsigner?

greenart7c3 commented 7 months ago

Yes, in amethyst we do that when you call the get public key the signer return its package name so you can save it. I also updated the readme with instructions on how to setup the androidmanifest.xml and check of there's a external signer installed

https://github.com/vitorpamplona/amethyst/blob/f1388b46d5d430cad760934ce3dcdfb0adc16185/app/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedOff/LoginScreen.kt#L200

https://github.com/vitorpamplona/amethyst/blob/main/quartz/src/main/java/com/vitorpamplona/quartz/signers/NostrSignerExternal.kt

https://github.com/vitorpamplona/amethyst/blob/main/quartz/src/main/java/com/vitorpamplona/quartz/signers/ExternalSignerLauncher.kt