dluxhu / perl-parallel-forkmanager

Parallel::ForkManager
20 stars 11 forks source link

Fix invalid default error when using old Moo #42

Closed ferki closed 1 month ago

ferki commented 1 month ago

This PR attempts to fix #41 by bumping the minimum Moo dependency version to 1.001000.

This is my first contribution here, and I wondered about the accepted contributing guidelines. Hope this fits already as-is, though please do let me know if you prefer anything changed (commit message, rebase/split/squash commits, changelog entry, and so on.) I'm happy to send follow-up updates as needed.

Please review, then either merge or let me know how to improve it.

yanick commented 1 month ago

The PR is perfect as-is. This project only gets one issue/PR per year, max, so I'm pretty easy-going as far as the process goes. :-) I'm testing and merging to master as we speak, and it should be deployed within the hour.

yanick commented 1 month ago

Aaand it's merged and pushed to cpan! Thanks!

ferki commented 1 month ago

Thank you, @yanick! :rocket:

yanick commented 1 month ago

Mah pleasure. :-)