Don't write debug.log - Githubissues

dlvhdr / diffnav

A git diff pager based on delta but with a file tree, à la GitHub.

MIT License

257 stars 4 forks source link

Don't write debug.log #11

Closed brandonchinn178 closed 3 weeks ago

brandonchinn178 commented 3 weeks ago

When running diffnav, I see a debug.log file being written to the current directory. It should either go to standard log locations, /tmp, or only written if debug mode is enabled

brandonchinn178 commented 3 weeks ago

Thank you!

aschey commented 2 weeks ago

I think this is still an issue because the environment variable isn't being checked here: https://github.com/dlvhdr/diffnav/blob/3f9a3cd8008d9a0167feacb8badff692d519ad24/main.go#L38

dlvhdr commented 2 weeks ago

Fixed by #34