Arrays filling improvement and some tidy up.

dlwh / epic

**Archived** Epic is a high performance statistical parser written in Scala, along with a framework for building complex structured prediction models.

http://scalanlp.org/

Apache License 2.0

469 stars 82 forks source link

Arrays filling improvement and some tidy up. #50

Closed jovilius closed 8 years ago

jovilius commented 8 years ago

Hi @dlwh,

the goals of this PR are:

removing some boilerplate when filling arrays
optimizing lenght and empty check on arrays
doing some general tidy up

dlwh commented 8 years ago

thanks for doing this! My biggest concern is with Array.fillWith (which should just be array.tabulate, anyway). A lot of places where I used a while loop is near an inner loop.

jovilius commented 8 years ago

replaced by https://github.com/dlwh/epic/pull/51