search

dlyldxwl / Stronger-One-stage-detector-with-much-Tricks

Stronger SSD & YOLO v3
39 stars 12 forks source link

find a bug about train on giou_loss #1

Open cxf2015 opened 5 years ago

cxf2015 commented 5 years ago

in box_uils.py: decode() function boxes[:, :2] -= boxes[:, 2:] / 2 boxes[:, 2:] += boxes[:, :2] have inplace operation error. should be change to: boxes_temp1=boxes[:,:2]-(boxes[:, 2:] / 2) boxes_temp2=boxes[:, 2:]+boxes[:, :2] boxes_out=torch.cat((boxes_temp1,boxes_temp2),1)

dlyldxwl commented 5 years ago

@cxf2015 This inplace operation is correct. The result of GIOU with SSD is worse, only 78+. How about you ?

dlyldxwl commented 5 years ago

About GIOU, I update the loss.py and detection.py files ( for bbox after decode, apply min and max function to get the left-up and right-down points). Furthermore, update the best result, 80.58.