search

dm-drogeriemarkt / foreman_vault

Foreman integration with Vault
GNU General Public License v3.0
18 stars 10 forks source link

Support for safe mode preview #37

Closed kamils-iRonin closed 3 years ago

kamils-iRonin commented 3 years ago

after merging https://github.com/theforeman/foreman/pull/8039, template rendering is broken and the error is ArgumentError: unknown keyword: :renderer

kamils-iRonin commented 3 years ago

fixes #36

laugmanuel commented 3 years ago

@timogoebel, I guess we can and should merge this PR and release a new version for Foreman 2.3 as https://github.com/theforeman/foreman/pull/8039 is part of that release and the plugin is therefore broken atm.

The current implementation would mean, that the new Plugin release is incompatible with 2.2 and older.

laugmanuel commented 3 years ago

Thanks @kamils-iRonin !

laugmanuel commented 3 years ago

@laugmanuel: Can you take care of the release?

Sure - are we ready for a new major version (1.0.0) as this is a breaking change for older Foreman versions?

timogoebel commented 3 years ago

are we ready for a new major version (1.0.0) as this is a breaking change for older Foreman versions?

Yes, definitely!

laugmanuel commented 3 years ago

I've released foreman_vault 1.0.0 and opened a PR for packaging: https://github.com/theforeman/foreman-packaging/pull/6178 This will be cherry-picked into rpm/2.3 after merge.