search

dm-nosov / alle-cafes

https://alle-cafes.vercel.app
1 stars 0 forks source link

Implement US2. Preview website sections #5

Closed dm-nosov closed 1 year ago

dm-nosov commented 1 year ago

Please read the feature details at: US2

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
alle-cafes ✅ Ready (Inspect) Visit Preview Aug 2, 2023 9:05am
dm-nosov commented 1 year ago

Hi Alina, thanks a lot for the review!

Regarding the console.log and the mock data, I would leave these fragments as is for now since I would anyway remove the data in favor of DB in the next US, and the console.log is needed for now to check the re-rendering rate.

As for the classes usage, I will consult with the coaches to understand what rationale stood behind this limitation and refactor them if it stands.

dm-nosov commented 1 year ago

Alina, I've discussed the usage of classes in these particular cases (global styles, injecting fonts) with a coach, and they are ok with it. In the areas where I can style a component independently, I will use (and currently use) the styled library.