dm-vdo / kvdo

A kernel module which provide a pool of deduplicated and/or compressed block storage.
GNU General Public License v2.0
239 stars 45 forks source link

kvdo-6.2.6.3 does not build against 5.17.4-200.fc35 #54

Closed andreamtp closed 2 years ago

andreamtp commented 2 years ago

I'm on Fedora 35 on x86_64 and I'm using kmod-kvdo-6.2.6.3-2.fc35 from copr:copr.fedorainfracloud.org:rhawalsh:dm-vdo .

Upgrading from kernel 5.16.20-200.fc35 to 5.17.4-200.fc35 result in build errors

DKMS make.log for kvdo-6.2.6.3 for kernel 5.17.4-200.fc35.x86_64 (x86_64)
Thu 28 Apr 13:50:15 CEST 2022
make: Entering directory '/usr/src/kernels/5.17.4-200.fc35.x86_64'
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/bits.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/buffer.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/actionManager.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/bufferedReader.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/adminCompletion.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/bufferedWriter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/adminState.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/cacheCounters.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/cachedChapterIndex.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/allocatingVIO.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/chapterIndex.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/allocationSelector.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/chapterWriter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/config.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/blockAllocator.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/deltaIndex.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/blockMap.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/deltaMemory.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/blockMapPage.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/errors.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/blockMapRecovery.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/geometry.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/blockMapTree.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/hashUtils.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/completion.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/index.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexCheckpoint.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/compressedBlock.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexComponent.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/compressionState.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/constants.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexConfig.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/dataVIO.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexInternals.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexLayout.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/dirtyLists.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/extent.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexLayoutLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexLayoutParser.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/fixedLayout.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexPageMap.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/flush.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/forest.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/hashLock.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexRouter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexSession.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/hashZone.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/header.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexState.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexStateData.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/heap.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/intMap.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexVersion.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/lockCounter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/indexZone.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/logicalZone.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/ioFactoryLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/lz4.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/packer.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/loadType.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/partitionCopy.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/logger.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/pbnLock.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/loggerLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/pbnLockPool.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/masterIndex005.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/masterIndex006.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/physicalLayer.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/physicalZone.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/pointerMap.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/masterIndexOps.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/memoryAlloc.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/memoryLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/nonce.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/numeric.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/priorityTable.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/openChapter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/openChapterZone.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/pageCache.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/readOnlyNotifier.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/permassert.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/permassertLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/random.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/recordPage.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/readOnlyRebuild.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/request.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/requestQueueKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/recoveryJournal.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/recoveryJournalBlock.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/searchList.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/recoveryUtils.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/sparseCache.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/refCounts.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/referenceCountRebuild.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/referenceOperation.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/stringLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/slab.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/stringUtils.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/slabDepot.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/sysfs.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/slabJournal.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/threadCondVarLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/slabJournalEraser.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/threadOnce.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/threadRegistry.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/threadsLinuxKernel.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/slabScrubber.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/slabSummary.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/timeUtils.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/udsMain.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/statusCodes.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/superBlock.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/udsModule.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/threadConfig.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/volume.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/volumeStore.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/trace.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/zone.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/upgrade.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdo.o
/var/lib/dkms/kvdo/6.2.6.3/build/uds/threadsLinuxKernel.c: In function ‘exitThread’:
/var/lib/dkms/kvdo/6.2.6.3/build/uds/threadsLinuxKernel.c:153:3: error: implicit declaration of function ‘complete_and_exit’ [-Werror=implicit-function-declaration]
  153 |   complete_and_exit(completion, 1);
      |   ^~~~~~~~~~~~~~~~~
/var/lib/dkms/kvdo/6.2.6.3/build/uds/threadsLinuxKernel.c:154:1: error: ‘noreturn’ function does return [-Werror]
  154 | }
      | ^
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoDebug.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/murmur/MurmurHash3.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoLayout.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoLoad.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/util/eventCount.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/uds/util/funnelQueue.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoPageCache.o
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:288: /var/lib/dkms/kvdo/6.2.6.3/build/uds/threadsLinuxKernel.o] Error 1
make[2]: *** Waiting for unfinished jobs....
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoRecovery.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoResize.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoResizeLogical.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoResume.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoState.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vdoSuspend.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vio.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vioPool.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vioRead.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/vioWrite.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/volumeGeometry.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/base/waitQueue.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/batchProcessor.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/bio.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/bufferPool.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/dataKVIO.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/deadlockQueue.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/dedupeIndex.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/deviceConfig.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/deviceRegistry.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/dmvdo.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/dump.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/errors.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/histogram.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/instanceNumber.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/ioSubmitter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/kernelLayer.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/kernelVDO.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/ktrace.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/kvdoFlush.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/kvio.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/limiter.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/logger.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/memoryUsage.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/poolSysfs.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/poolSysfsStats.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/sysfs.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/threadDevice.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/threadRegistry.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/threads.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/udsIndex.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/vdoStringUtils.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/verify.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/workItemStats.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/workQueue.o
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/workQueueHandle.o
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/batchProcessor.c: In function ‘makeBatchProcessor’:
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/batchProcessor.c:172:17: error: cast between incompatible function types from ‘BatchProcessorCallback’ {aka ‘void (*)(struct batchProcessor *, void *)’} to ‘void (*)(KvdoWorkItem *)’ {aka ‘void (*)(struct kvdoWorkItem *)’} [-Werror=cast-function-type]
  172 |                 (KvdoWorkFunction) callback, CPU_Q_ACTION_COMPLETE_KVIO);
      |                 ^
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/workQueueStats.o
cc1: all warnings being treated as errors
  CC [M]  /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/workQueueSysfs.o
make[2]: *** [scripts/Makefile.build:288: /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/batchProcessor.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:550: /var/lib/dkms/kvdo/6.2.6.3/build/uds] Error 2
make[1]: *** Waiting for unfinished jobs....
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c: In function ‘statusDedupeOpen’:
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c:79:46: error: implicit declaration of function ‘PDE_DATA’; did you mean ‘NODE_DATA’? [-Werror=implicit-function-declaration]
   79 |   return single_open(file, statusDedupeShow, PDE_DATA(inode));
      |                                              ^~~~~~~~
      |                                              NODE_DATA
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c:79:46: error: passing argument 3 of ‘single_open’ makes pointer from integer without a cast [-Werror=int-conversion]
   79 |   return single_open(file, statusDedupeShow, PDE_DATA(inode));
      |                                              ^~~~~~~~~~~~~~~
      |                                              |
      |                                              int
In file included from /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.h:27,
                 from /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c:35:
./include/linux/seq_file.h:165:68: note: expected ‘void *’ but argument is of type ‘int’
  165 | int single_open(struct file *, int (*)(struct seq_file *, void *), void *);
      |                                                                    ^~~~~~
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c: In function ‘statusKernelOpen’:
/var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c:181:46: error: passing argument 3 of ‘single_open’ makes pointer from integer without a cast [-Werror=int-conversion]
  181 |   return single_open(file, statusKernelShow, PDE_DATA(inode));
      |                                              ^~~~~~~~~~~~~~~
      |                                              |
      |                                              int
In file included from /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.h:27,
                 from /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.c:35:
./include/linux/seq_file.h:165:68: note: expected ‘void *’ but argument is of type ‘int’
  165 | int single_open(struct file *, int (*)(struct seq_file *, void *), void *);
      |                                                                    ^~~~~~
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:288: /var/lib/dkms/kvdo/6.2.6.3/build/vdo/kernel/statusProcfs.o] Error 1
make[1]: *** [scripts/Makefile.build:550: /var/lib/dkms/kvdo/6.2.6.3/build/vdo] Error 2
make: *** [Makefile:1841: /var/lib/dkms/kvdo/6.2.6.3/build] Error 2
make: Leaving directory '/usr/src/kernels/5.17.4-200.fc35.x86_64'

Booting with kernel 5.16 restore functionality, but would be appreciated if module could be loaded in 5.17 as well.

Thanks

tigerblue77 commented 2 years ago

Hello,

Solution seems to be here :

tabowling commented 2 years ago

After upgrading from F35 to 36, my Fedora hypervisor is now useless since my VM pool is on a VDO block device. Much appreciation to a quick resolution to this.

Are we any closer to kvdo being in mainline kernel and Fedora distribution? Many Thanks, Terry

rhawalsh commented 2 years ago

Hi @tabowling, we are getting closer and closer every day for getting our mainline contribution out. Most of the major tasks that we have identified at this point have been addressed and we're just working on buttoning up the various low-level items that remain.

For your Fedora hypervisor being F36, can you provide details on how you are consuming the VDO code? That will help me with ensuring that we can help you get back up and running as soon as possible.

I will take ownership of this issue moving forward to help get it resolved.

glvxar commented 2 years ago

Same issue, i had to downgrade f36 to f35 with kernel 5.14.10-300.fc35 so i can use vdo volume and start vms again. i have tried the rpm on copr.

i would really apreciate this works on f36 so i can do the upgrade.

rhawalsh commented 2 years ago

I have just updated my forks to build and run on the current version of Fedora 35 and Fedora 36. I have tested it to work up to kernel 5.17, but I believe there is a lingering issue on 5.18 that some others have reported where we encounter a NULL pointer. That is still being investigated by the team.

Sadly (or luckily?), neither the released versions nor the Rawhide version of Fedora is currently using the 5.18 kernel. Currently Fedora 35 and Fedora 36 are running on a 5.17 kernel, and Rawhide is pointing at a 5.19 kernel. Though I suspect the 5.18 kernel is probably going to be coming soon, since I see some recent 5.18 builds on koji.

But for now, if you look at my forks for kvdo and vdo, they will build on kernels up to the currently available version on Fedora. Similarly the dm-vdo COPR has been updated with builds for these releases.

tigerblue77 commented 2 years ago

Hello @rhawalsh, why do all RedHat VDO's team members all fork this repository instead of working into branches ? And why don't you merge/pull request into this main repository ? I think it's not a good practice and will cause you problems when you will want to merge all repositories.

rhawalsh commented 2 years ago

Hi @tigerblue77, unfortunately, it's an artifact of our workflow that isn't easy to overcome. However, as I had mentioned in the first paragraph of another thread, we have some changes coming up to our workflow that will make things easier. Stay tuned.

grz0 commented 2 years ago

I updated kvdo to kmod-kvdo-6.2.7.9-2.fc36.x86_64 from dm-vdo COPR, it works fine with 5.17.14-300.fc36.x86_64 kernel.

rhawalsh commented 2 years ago

Hi @grz0, thanks for the confirmation.

Just a heads up... If you notice that the 5.18 kernel becomes available, please hold off on updating to it. There is a known issue that triggers a NULL pointer error. I am away from the office until Monday evening, so I can't fix it until then if it shows up.

andreamtp commented 2 years ago

Hi Andy, welcome back! On F36 stable kernel-5.17.13-300.fc36.x86_64 your module rebuild 6.2.7.9-2.fc36 installed correctly.

Before that I was using 8.2.0.0 self build out of desperation, given the ton of errors with vdo 6.2.x.x build on 5.17 was producing. FYI kernel.x86_64 5.18.5-200.fc36 hit the stable repo, so you may want to put it on hold via rpm deps.

can you provide details on how you are consuming the VDO code

My usages is as local dedup volume, no compression, on RAID1 SSD for my local virtualization host, running Fedora stable. The kernel change after the upgrade to F36 hit me hard, forcing me to downgrade the kernel - not really pleasant.

Given the "officially unofficial" rpm copr repo has now a stable build, I'm closing this issue.

tigerblue77 commented 2 years ago

Hello, Maybe that you should not close this issue until it's merges into this repository ?

PS for RH team : I'll answer my opened issues but I'm very busy these last weeks