search

dm3 / clojure.java-time

Java 8 Date-Time API for Clojure
MIT License
461 stars 45 forks source link

Cut new release for Clojure 1.11 compat? #84

Closed DerGuteMoritz closed 1 year ago

DerGuteMoritz commented 2 years ago

Given that Clojure 1.11 is about to be released any day now, how about cutting a new release which includes https://github.com/dm3/clojure.java-time/pull/83 to get rid of the warning? Thanks for the library! :pray:

Heliosmaster commented 2 years ago

Given that Clojure 1.11 is about to be released any day now, how about cutting a new release which includes #83 to get rid of the warning? Thanks for the library! 🙏

In the meantime, if you use deps.edn you can just use the revision https://github.com/dm3/clojure.java-time/commit/f9e11c3f852c14adf579d5101e7e98ec198eb343 in your code

DerGuteMoritz commented 2 years ago

In the meantime, if you use deps.edn you can just use the revision f9e11c3 in your code

Unfortunately not because that would also require clojure.java-time to have a deps.edn which it doesn't, yet :grimacing:

Heliosmaster commented 2 years ago

whoops, missed that. Can still fork and add it tho 😅

DerGuteMoritz commented 2 years ago

Heh yeah went ahead and did just that. See https://github.com/dm3/clojure.java-time/pull/85.

dm3 commented 2 years ago

Sorry guys, I'm really behind on maintaining this library as I haven't worked with Clojure for years now. Does anyone want to become a maintainer or take over?

frenchy64 commented 2 years ago

I use this library at work, I can be a maintainer. I have a few PR's open here with fixes. I also know that I don't know a lot about time, so I won't be making any sweeping changes.

FWIW I'm also a maintainer of schema and plumbing for similar reasons.

aneilbaboo commented 2 years ago

@dm3 - bumping this in case you hadn't seen it. It would be great to get v0.3.4 published. The abs symbol collision in Clojure 1.11 is causing problems in my IDE:

image
edporras commented 2 years ago

@frenchy64 I can also help maintain, even though I'm also no time expert 😅

I would also like to get a new release published.

aneilbaboo commented 2 years ago

Hi @dm3 - just pinging you in the hope you'll see the above messages from @edporras and @frenchy64

dm3 commented 2 years ago

yep, thanks! I've just sent a collaboration invite to @frenchy64.

frenchy64 commented 2 years ago

@dm3 thanks, please also add https://clojars.org/users/frenchy64 to the https://clojars.org/clojure.java-time group so I can deploy.

frenchy64 commented 1 year ago

It doesn't look like @dm3 is monitoring this repo, I might deploy it somewhere else.

huima commented 1 year ago

I wonder if there is another way to reach him through some other channel instead of starting to publish to some other place.

Would be nice if someone in the Clojure community knows him otherwise:

https://twitter.com/huima/status/1559511570140610562

huima commented 1 year ago

Another option could be to open the ticket with Clojars ( https://github.com/clojars/clojars-web/wiki/Contact ) and see if the issue could be resolved through their help. Not sure if there exists yet a process for deciding if the initial maintainer has properly abandoned the project in a way that new maintainers could be given rights also to clojars.

I'll ping them via email - and ask what would be a proper way to proceed if they could investigate giving permissions to clojars that reflect project's current maintainer status too.

Sent email to maintainers with the link to this issue, so that they could reply if there is a process to change permissions -- or if the project needs to be published elsewhere. If I get reply, will update here. If nothing is heard for sometime, then it seems possible that alternative publishing path is needed.

aneilbaboo commented 1 year ago

@tobias @danielcompton - the original owner of this repo (@dm3) transferred it to @frenchy64 and others, but did not add them to the Clojars repo, and also isn't monitoring Github anymore, it seems.

What is the right way to get this resolved?

tobias commented 1 year ago

Hi all! We should be able to help out here. Based on my reading of this issue, it does seem like @dm3's intent is to let @frenchy64 be a maintainer, which would include Clojars deploy rights. I have emailed the address we have on file for @dm3 in Clojars to confirm that, and I can add @frenchy64 to the group when I hear back.

If I don't hear back in a reasonable time (a few days), we can discuss other options.

arohner commented 1 year ago

@tobias Any updates?

tobias commented 1 year ago

@arohner: Sorry for the delay here. I haven't heard anything back from @dm3.

Given the discussion here, I think it's fine to give @frenchy64 access to the group on Clojars. I'm away from a computer the rest of the month, but @danielcompton should be able to help.

danielcompton commented 1 year ago

Yep I'll do this in the next day or so.

danielcompton commented 1 year ago

@frenchy64 you are now an admin for the clojure.java-time group on Clojars, along with @dm3.

frenchy64 commented 1 year ago

@danielcompton there's a typo: I'm frenchy64, you seem to have given french64 access.

danielcompton commented 1 year ago

@frenchy64 sorry about that, I've removed the (nonexistent) user french64 and added you.

There were no new versions published during this period.

frenchy64 commented 1 year ago

Thanks! Released 1.0.0.