search

dm82m / hass-Deltasol-KM2

Custom component for retrieving sensor information from Resol KM1/KM2, DL2/DL3, VBus/LAN, VBus/USB
MIT License
25 stars 6 forks source link

Auto detect Mode enhanced #12

Closed ostat closed 2 years ago

ostat commented 2 years ago

Separated the Auto detect logic from the fetch data call.
Modified Auto Detect mode so result is cached, only runs first time after startup. Re added the ability to set the mode in config if user desires (separate commit if this is not wanted). Hid password when logging the URL.

dm82m commented 2 years ago

In general I like the approach! But we need ensure that the auto detect works. As I said above, if we turn it and try to parse the result to json or if we check what the answer of km2 is on dlx url request we can change it and go tot this

dm82m commented 2 years ago

@ostat and @chiefdeputy can you have a rough look on the dev branch, it includes the last squashed version of chris commit on this PR here and also the first improvement for #13 - if you agree I would merge that know ...

ostat commented 2 years ago

Can do.

A bit off topic, what's your workflow when working on HA plugins. Do you have the repo checked out in the HA folder?

I have it checked out to another location and manually sync as needed. It's a bit cumbersome though, esp when changing branches.

dm82m commented 2 years ago

Can do.

A bit off topic, what's your workflow when working on HA plugins. Do you have the repo checked out in the HA folder?

I have it checked out to another location and manually sync as needed. It's a bit cumbersome though, esp when changing branches.

I copy&replace the changes from my local dev files (mac) into HA (using file editor there). in rare cases I create pre-release based on a branch and directly use the update mechanism in HACS. but yes, I also have no real "good workflow" for it...

dm82m commented 2 years ago

also added #14