search

dma61 / VBPUOdsk

3 stars 0 forks source link

May Schema puvCode references #60

Closed h-jos closed 1 week ago

h-jos commented 4 months ago

In the new May schemas, the puvCode references are as follows:

1A: "$ref": "VBPUO-001.00-Bericht_1.Vermogen(0001a)-afdCodelists.json#/definitions/AFDIDP" 1B: "$ref": "VBPUO-001.00-Bericht_2.Cashflow(0001b)-afdCodelists.json#/definitions/AFDIDP", 1C: "$ref": "VBPUO-001.00-Bericht_3.Pensioenprojectie(0001c)-afdCodelists.json#/definitions/AFDIDP",

These references for puvCode are not accessible within the schema --- they don't point to other parts of the schema or an external website. All other references in the schemas to code lists look like: "https://www.sivi.org/afd-online-tool/json/AFDRES.json#/definitions/AFDRES.

Can the reference for puvCode be modified such that it is as follows: "$ref": "https://www.sivi.org/afd-online-tool/json/AFDIDP.json#/definitions/AFDIDP",

dma61 commented 4 months ago

SIVI internal: https://stichtingsivi.atlassian.net/browse/TAAK-941

dma61 commented 2 weeks ago

Attention: Commit a654942 only solves this issue for message 6 orderconfirmation

dma61 commented 1 week ago

@h-jos please close the issue after checking.

h-jos commented 1 week ago

The fix was made in v 1.0.3 --- Commit c6bb9d5. The updates meet the requirement. Will close this issue.