search

dmac / fezzik

A light deployment system that takes care of the heavy lifting.
https://rubygems.org/gems/fezzik
MIT License
37 stars 6 forks source link

Exit #44

Closed veenstra closed 11 years ago

veenstra commented 11 years ago

If a command calls exit with a status of 0, it should not be displayed as "fail".

dmac commented 11 years ago

Thanks Jack, this change is good. Can you resubmit a new pull request without the version bump? Generally only the maintainer should bump the version whenever a release is cut.

veenstra commented 11 years ago

Okay, I didn't know what the convention was. I thought putting the version change in a commit by itself was sufficient. But I created a new branch "exit0" and sent you a pull request.

Jack

On Tue, Jan 29, 2013 at 12:03 PM, Daniel MacDougall < notifications@github.com> wrote:

Thanks Jack, this change is good. Can you resubmit a pull request without the version bump? Generally only the maintainer should bump the version whenever a release is cut.

— Reply to this email directly or view it on GitHubhttps://github.com/dmacdougall/fezzik/pull/44#issuecomment-12854707.