search

dmacfarlane / angular-mentions

Angular mentions for text fields.
MIT License
196 stars 171 forks source link

Incorrect peer dependency range #238

Open szuperaz opened 1 year ago

szuperaz commented 1 year ago

Hi,

The peer dependency range inside the lib's pacakge.json seems to be incorrect:

"peerDependencies": {
  "@angular/common": ">=7.2.0",
  "@angular/core": ">=7.2.0"
}

When installing version1.5.0 inside an Angular@12 package this runtime error occurs:

This application depends upon a library published using Angular version 14.0.6, which requires Angular version 14.0.0 or newer to work correctly.
Consider upgrading your application to use a more recent version of Angular.

This is a related issue from Angular: https://github.com/angular/angular/issues/46748 - especially this comment: https://github.com/angular/angular/issues/46748#issuecomment-1178817658, which explains that if a library is built with version 14 it won't be compatible with older versions of Angular.

I believe this error was introduced in version 1.5.0 when Angular was updated to version 14, and the library was compiled using Angular 14, technically making the release a breaking change.

For now, I can use 1.4.0 instead of ^1.4.0 but I believe for future releases it's cleaner if these updates are marked as breaking changes and the peer dependency range is correctly specified in pacakge.json.