dmachat / angular-datamaps

Angular directive for d3 Datamaps
MIT License
60 stars 30 forks source link

better to use $watchCollection #11

Closed leonardean closed 9 years ago

leonardean commented 9 years ago

coz $watch can not detect changes in data. is there a max limit for number of colours?

dmachat commented 9 years ago

Actually, $watch with the deep equality check set to true does check for changes in the data. $watchCollection is a shallow check. I've changed the way the watcher works in v0.1.0, so check to see if you still have any issues. Also, the api for colors has changed, and they are now set in the fills array, like Datamaps. Should not be a limit.