search

dmachat / angular-datamaps

Angular directive for d3 Datamaps
MIT License
60 stars 30 forks source link

No way to pass data to plugins #17

Closed kfeinUI closed 9 years ago

kfeinUI commented 9 years ago

Unless I'm mistaken, I don't see a way to pass in plugin-specific data. It would be helpful to have this exposed through perhaps another directive that will apply the data when it changes.

For example, there's no way to supply data to the Datamaps core bubbles plugin. This may only be done if you have a handle on the Datamap instance and call map.bubbles([...]).

The effort is appreciate here. Thanks!

adrianbj commented 9 years ago

Just wanted to say a big thanks for this - went to start adding bubbles today, found this and it's working great!

I hope to see this PR accepted ASAP.

Just a small correction to the additions to the ReadMe. You have a misplaced: }; The one on the last line should be just before: $scope.mapPluginData = {

kfeinUI commented 9 years ago

Good catch, @adrianbj . I've amended the commit with this minor fix.

dmachat commented 9 years ago

Merged and released in v0.1.2. Thanks!

7obias commented 5 years ago

is there a way to pass options to the bubbles plugin? e.g. for a custom popupTemplate