search

dmachi / Titanium-CommonJS

CommonJS module for Appcelerator Titanium which provides a require() statement to load common js modules
15 stars 0 forks source link

Found typo while browsing... #1

Open Mantic opened 12 years ago

Mantic commented 12 years ago

line 67 of lib/worker.js:

Titanium.API.debugh("create Worker()");

is that supposed to be "debugh" vs "debug"?

dmachi commented 12 years ago

Yeah, i'm sure it is. I believe they have require() built into titanium now, so i haven't checked on it lately.

Mantic commented 12 years ago

They have one on their mobile side of things, but I still haven't seen it as of the 1.2.0 desktop SDK. I got your module to install and run, but no matter what it returns with an error: "Unable to resolve require: js/test". (given that I passed 'js/test' to the function) I suppose that's another issue though...

dmachi commented 12 years ago

Yeah, it is probably way out of date. I'd recommend using the latest dojo and load it with the new loader (not in backcompat mode) Since the newer versions of dojo are basically following AMD, it is not as critical to load the way it did before...or even better replace this module by building the loader in as a module. There is a dojo dev that works on Titanium, I can ping him and ask him what he does for this currently if you like.

Dustin

On Nov 26, 2011, at 7:50 PM, Michael Whitaker wrote:

They have one on their mobile side of things, but I still haven't seen it as of the 1.2.0 desktop SDK. I got your module to install and run, but no matter what it returns with an error: "Unable to resolve require: js/test". (given that I passed 'js/test' to the function) I suppose that's another issue though...

Reply to this email directly or view it on GitHub: https://github.com/dmachi/Titanium-CommonJS/issues/1#issuecomment-2885035