search

dmaclean / dfs-python

Tools for DFS data collection and projection creation.
11 stars 2 forks source link

Some functions aren't accounting for games player didn't participate in. #20

Closed dmaclean closed 10 years ago

dmaclean commented 10 years ago

The query used to generate depth charts is an offender of this. It is only checking _game_totalsbasic which won't have a row if the player didn't play (see Andrew Bynum after mid December 2013). So, it's still showing him averaging 20 minutes a game when he hasn't played in a 1.5 months.

Another offender is _get_avg_stat_past_ngames.

Fix this shit.

dmaclean commented 10 years ago

Just kidding. I think the current implementation is correct. It makes sense that Bynum averaged 20 minutes/game, as long as it's understood that the context is games he played in. A better option might be to add some date or game checking to take into account that the player has missed games.