Fix firmware for armv7l

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt

Apache License 2.0

1.58k stars 456 forks source link

Fix firmware for armv7l #1046

Closed thequailman closed 7 months ago

thequailman commented 10 months ago

armv7l needs the same firmware as aarch64:

From a vanilla arm libvirt config:

<domain type="qemu">
  <os firmware="efi">
    <type arch="armv7l" machine="virt-7.2">hvm</type>
    <boot dev="hd"/>
  </os>

michaelbeaumont commented 10 months ago

Thanks @thequailman

I'm not familiar with why even aarch64 needs "efi". Is it about a sensible default or is it impossible to run without firmware="efi"?

thequailman commented 10 months ago

I believe with qemu it's required to use EFI/impossible to boot. I am happy to turn this (and the aarch64 version) into a config value instead of an implicit default.