search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.58k stars 456 forks source link

Add Combustion resource to use instead of the ignition one #1068

Closed cbosdo closed 1 month ago

cbosdo commented 7 months ago

Since combustion is very similar to ignition, add another resource based on the ignition one, just adding a flag to disable the JSON unmarshalling error.

dmacvicar commented 6 months ago

I am ok with the hack, but I think a comment above the flag should make explicit what we are doing.

cbosdo commented 5 months ago

I am ok with the hack, but I think a comment above the flag should make explicit what we are doing.

Sorry for the late reply. I added a comment on the Combustion member of the definition. I hope that's what you meant.

dmacvicar commented 1 month ago

Integration tests are broken after I merged:

image

cbosdo commented 3 weeks ago

Integration tests are broken after I merged:

image

Just saw the message after vacation and filed a PR to fix it.