search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.6k stars 458 forks source link

Small enhancements: [3] #509

Open mykaul opened 5 years ago

mykaul commented 5 years ago

Enhancement: ability NOT to configure display at all

It'd be nice not to configure a display - graphics or video device, at all. With console (virtio or not), they are many times not needed at all.

mykaul commented 5 years ago

I assume the fix should be @ https://github.com/dmacvicar/terraform-provider-libvirt/blob/e0e8029af6fb17e6ec35f659b78bbcc42c900ca7/libvirt/domain.go#L278 - Something like:

domainDef.Devices.Graphics = nil
return nil

instead of the error.

MalloZup commented 5 years ago
scabala commented 1 month ago

Related to #746