search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.6k stars 459 forks source link

Allow setting for disk mode sata #535

Open abbbi opened 5 years ago

abbbi commented 5 years ago

hi,

currently the plugin only supports two disk types: virtio(-scsi) and virtio. IDE is used for CDROM.

There are certain systems that dont work with the scsi or virtio option. Some might need SATA (like ESXi).

There should be the possiblity to specify SATA as disk bus option too.

MalloZup commented 5 years ago

@abbbi for all this extension features, you can use this: https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/website/docs/r/domain.html.markdown#altering-libvirts-generated-domain-xml-definition

:rocket:

abbbi commented 5 years ago

@MalloZup

yes i know, but then it might also make sense to have something like:

disk { type = "sata|scsi|virtio-scsi|ide" .. }

instead of forcibly defaulting to some value. Also, different disk modes require different controllers to be added.

MalloZup commented 5 years ago

yop i get the point