search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.59k stars 458 forks source link

Ubuntu cluster module with kubernetes cluster layered on top #712

Open castleguarders opened 4 years ago

castleguarders commented 4 years ago

Please make sure you read the contributor documentation before opening a Pull Request.

MalloZup commented 4 years ago

@castleguarders thx for PR and effort! I think your PR is way to much for the examples.

Let me explain. The examples directory are more something that we try to maintain for showcasing the functionality of the provider libvirt itself. For community based projects we have another section.

If you want to show-case your project, I would rather suggest you to provide a link here :

https://github.com/dmacvicar/terraform-provider-libvirt#upstream-projects-using-terraform-libvirt

But before this, I would like to understand why you think the community would profite from your project, so I would like to hear more about your motivation/description why you think it is useful.

Part of this, thx for pr and effort :green_heart:

castleguarders commented 4 years ago

@MalloZup I felt the same, however thought it might be a better home than a stray standalone somewhere. Maybe a better medium is to cull out the kubernetes parts and just leave the VM cluster as the example. The cluster should fit better as an example, as it was based on the existing examples. It was just made more modular in keeping with terraform guidelines. Let me know if this approach works, and i will trim it down.

Also, the reason that pushed me over to include the kubernetes part was that the existing terraform providers always seem to have dependencies with "cloud" providers. I figured it might help someone else trying to accomplish it locally.

MalloZup commented 4 years ago

we have also this directory contrib

https://github.com/dmacvicar/terraform-provider-libvirt/tree/master/contrib

If you manage to refactor the documentation, with index and improve the documentation in that directory and the readme, (stating that the contrib are community driven example, with index to docker and k8s) I'm ok to put it on our umbrella on that dir. So it is less confusing.

Also these example , will be community effort and not directly maintained. thx !

MalloZup commented 4 years ago

I think we can have the contrib directory for examples, which are more then simple examples. :grin:

castleguarders commented 4 years ago

Sounds good @MalloZup. I'll work on your suggestions.

MalloZup commented 4 years ago

let me know when you have something