search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.59k stars 458 forks source link

Share nvram or don't remove nvram when vm destroyed? #758

Open tmpm697 opened 4 years ago

tmpm697 commented 4 years ago

System Information

Linux distribution

archlinux

Terraform version

Terraform v0.12.28

Provider and libvirt versions

terraform-provider-libvirt d1cf93cdb066b2d3d2c2c046d2fb986808d9a424
Compiled against library: libvirt 6.4.0
Using library: libvirt 6.4.0
Running hypervisor: QEMU 5.0.0
Running against daemon: 6.4.0

Description of Issue/Question

Setup

a vm that use EFI with nvram option in *.tf

Steps to Reproduce Issue

spin up bunch of vms with nvram option, each vm will need separate nvram file that will be destroyed with vm.

I want to use one nvram file for all vms that run EFI as they actually the same file that I use for all (just copy them)

scabala commented 2 weeks ago

I think it would be hard to properly track usages of that file across VMs. Also, it might happen that something else would try to use that nvram file, outside of Terraform so it could create issues when destroying last Terraform created VM using it.

I think this issue should be closed or considered to create a separate resource for nvram file - which I think is too much overhead.