search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.59k stars 458 forks source link

update vendor files #804

Closed chenrui333 closed 3 years ago

chenrui333 commented 3 years ago

Please make sure you read the contributor documentation before opening a Pull Request.

Fix the build issue.

go: inconsistent vendoring in /Users/rchen/open-source/terraform-provider-libvirt:
    github.com/google/uuid@v1.1.2: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/google/uuid@v1.1.1
    github.com/stretchr/testify@v1.5.1: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/stretchr/testify@v1.4.0
MalloZup commented 3 years ago

@chenrui333 thx for this PR!

Can you help me understand where do you encounter this issue, in which build system/workflow?

I have tried to run locally the actual branch and it works for me with make.

make
go fmt ./libvirt .
go run golang.org/x/lint/golint -set_exit_status ./libvirt .
go vet ./libvirt
go build -ldflags "-X main.version=$(git describe --always --abbrev=40 --dirty)"
dmaiocchi@linux-buft:~/bin/terraform-provider-libvirt>

Is this issue something is happening in bazel or other related repos? We would happy to accommodate other use-cases on building if it can help. :sunflower:

chenrui333 commented 3 years ago

trying to fix this PR, https://github.com/Homebrew/homebrew-core/pull/64483

Build run log in here, https://github.com/Homebrew/homebrew-core/runs/1385713468