search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.59k stars 458 forks source link

Support dnsmasq options #820

Closed Prashanth684 closed 3 years ago

Prashanth684 commented 3 years ago

So this is implementing #642 using datasource as suggested in the issue. The issue was closed at that time because of a workaround using xslt. But now we are seeing that this is needed for our Openshift CI for non-x86 arches which runs on libvirt. This would enable us to automate this option through the openshift installer byproviding it through the install-config at installation time.

Please make sure you read the contributor documentation before opening a Pull Request.

Prashanth684 commented 3 years ago

/cc @MalloZup @dmacvicar

Prashanth684 commented 3 years ago

@MalloZup thanks for the quick review! if the changes look good could these be merged please?

Prashanth684 commented 3 years ago

thank you so much @MalloZup !! just one follow up question - is there a plan to cut a v0.6.4 tag sometime soon ? i'm asking because we plan to use these changes in the openshift installer.

MalloZup commented 3 years ago

@Prashanth684 on the short-term for a 0.6.4 I think we might need to wait a bit.

Our focus is for a 0.7.0 with this mostly: https://github.com/dmacvicar/terraform-provider-libvirt/pull/813

for a 0.6.4 I think if we have like 3/4 PRs with some changes , I think we might be able to release this year a minor version in case is needed. this is my pov, maybe @dmacvicar has other thoughts, but I personally think a 0.6.4 in a short-term is not something we could be against. ( maybe we could have just the github release without pkg etc.).

Prashanth684 commented 3 years ago

@Prashanth684 on the short-term for a 0.6.4 I think we might need to wait a bit.

Our focus is for a 0.7.0 with this mostly: #813

for a 0.6.4 I think if we have like 3/4 PRs with some changes , I think we might be able to release this year a minor version in case is needed. this is my pov, maybe @dmacvicar has other thoughts, but I personally think a 0.6.4 in a short-term is not something we could be against. ( maybe we could have just the github release without pkg etc.).

@MalloZup agreed. I would definitely be ok with a minor release without pkgs, just something to vendor in is what i am looking for.

BTW, #813 is interesting. i will read a bit more and see if i can contribute to it is some way..

MalloZup commented 3 years ago

@Prashanth684 thx for your initiative and help.

Check also the channel/chat where we are discussing it a bit:

https://gitter.im/terraform-provider-libvirt/Lobby