Including the domain Id in the error output, when it couldn't retrieve IP address

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt

Apache License 2.0

1.54k stars 457 forks source link

Including the domain Id in the error output, when it couldn't retrieve IP address #843

Closed srbarrios closed 3 years ago

srbarrios commented 3 years ago

This is just a small addition to the error output when it couldn't retrieve the IP address.

As, using terraform from our Jenkins pipelines, the direct output we can see in the Jenkins console is not the log.Printf but the fmt.Errorf. So I hope that adding the domain id in this output, even if it could smell duplicated, will help people in our situation to discover which is the domain failing in case they have a long list of VMs to deploy.

MalloZup commented 3 years ago

thx!

Bischoff commented 3 years ago

will help a lot! thanks