search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.6k stars 460 forks source link

qemu agent support #879

Open stacab opened 3 years ago

stacab commented 3 years ago

/kind enhancement

Hi, currently, this provider does not support querying network data via qemu-agent. It is explicitly stated here. Underlying library, go-libvirt should support it via this command. It is necessary feature in case of IP address assigned via DHCP server.

I am willing to work on this if there's interest to merge it upstream.

mmolnar commented 3 years ago

Actually there is already an pull request #873 that solves this issue a bit more smoothly than directly using qemu agent commands.

I am unable to use newer versions (> 0.6.3) of this provider until this is resolved so this issue affects my environment.

stacab commented 3 years ago

Hi @mmolnar I've seen that PR and I think it might solve the issue.

dmacvicar commented 2 years ago

Unfortunately the PR is stale as requested changes were not provided. I will see if I can fix it myself.

scabala commented 2 months ago

I think this is already implemented - I'm using it daily

dmacvicar commented 2 months ago

Can you provide more details @scabala, then I can close this one?

scabala commented 2 months ago

The issue was about getting IP address from domain when network is using DHCP. I have been using such setup with dynamic address retrieved by Terraform when using QEMU agent for quite some time and it works - each time I get proper IP address. So I think this can be closed.