search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.54k stars 457 forks source link

RBD volume support #907

Open gxben opened 2 years ago

gxben commented 2 years ago

@dmacvicar This PR adds minimal changes to provide RBD volume support. As documented, it relies on libvirt sysadmin to have provisioned template images on the Ceph/RBD pool and have the named pool defined at libvirt's level first, as to minimize configuration impact at Terraform level.

libvirt currently does not support source volume copying through backing store for anything else than directory pool type. So when RBD volumes come into play, we use the volume clone and resize functions instead.

dmacvicar commented 2 years ago

@gxben thanks for the PR.

I don't know much about RBD. Why do we need to put configuration in the disk, instead of having a pool of type RBD and have the disk refer to the volume and pool by name/id?

gxben commented 2 years ago

Hi @dmacvicar , Care to detail which part of the "configuration in the disk" you mean so I can help ?