search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.54k stars 457 forks source link

Make 'option_value' for dnsmasq optional #960

Closed e4t closed 1 year ago

e4t commented 1 year ago

To support value-less dnsmasq options ('no-hosts') this change set makes option_value optional in which case option_name is inserted in the dnsmasq.conf without traling '='. While this change invalidates the separation into 'name' and 'value' to some extend, it retains compatibility. An update to the documentation and test cases are also included.

e4t commented 1 year ago

Hi @dmacvicar could you have a look at this? Thanks!

dmacvicar commented 1 year ago

I will look into this after I merge the SDK v2 update. Thanks.

dmacvicar commented 1 year ago

Thanks for the PR

e4t commented 1 year ago

Thanks for the PR

@dmacvicar Thanks for merging! - A belated Xmas present ;) ... and Happy New Year to you!