search

dmacvicar / terraform-provider-libvirt

Terraform provider to provision infrastructure with Linux's KVM using libvirt
Apache License 2.0
1.54k stars 457 forks source link

modify the volume size type to support units #974

Closed rgl closed 8 months ago

rgl commented 1 year ago

This allows us to specify the volume size as:

resource "libvirt_volume" "example_root" {
  size = "123GiB"
}

Currently, the units are case-insensitive, should they be case-sensitive?

Maybe also expand this to the other size/capacity properties like the memory size?

Please note that this is still missing the documentation.

dmacvicar commented 1 year ago

I am not convinced about this change, as it changes the type to string. Is it backward compatible?

Also, there is some push to have this in HCL itself: https://github.com/hashicorp/hcl/issues/326

rgl commented 1 year ago

I think we can still use size = 123. But I can confirm if this can go forward.

dmacvicar commented 8 months ago

Lets wait for native support in https://github.com/hashicorp/hcl/issues/326