dmadisetti / steam-tui

Rust TUI client for steamcmd
MIT License
857 stars 17 forks source link

blank games list after login -2 #73

Open zDEFz opened 5 months ago

zDEFz commented 5 months ago

provide a log with steam-tui 2> error.log

Closing because it seems like the initial error was fixed. Also added custom scripts to help with executables being off

Originally posted by @dmadisetti in https://github.com/dmadisetti/steam-tui/issues/62#issuecomment-2128309305

I did do that, but the error.log is absolutely empty!

dmadisetti commented 5 months ago

Woops. Thought I responded to this. Are you getting blank games or is the caching screen stuck?

Try flushing cache by removing ~/.cache/steam-tui/*

zDEFz commented 5 months ago

Okay, I did that. Same behavior!

So after flushing, I was not logged in, so I pressed l to sign in, and confirmed with enter. After that, I see just a blank list!

But now we got one entry in error.log:

steamcmd.sh[3073582]: Restarting steamcmd by request...

I then ran steamcmd again, and logged in, then I ran the latest git build again, and logged in. List is empty

Then I relaunched it, logged in again, and now suddenly I got a list, and it even found installed games! But... the error.log doesnt contain anything new! A bit unfortunate that the games launching that were set to proton do not launch in the same context and instead try baseline wine.

dmadisetti commented 5 months ago

Cool! So can we close this out? What system/ shell do you use though? This is still weird.

You can now write a script to do the launching yourself with proton. Or you can just replace wine with proton here https://github.com/dmadisetti/steam-tui/blob/f5d2a4f75ade23f21da18051a5469f2a084ec300/src/client.rs#L234

Thinking more on windows support, we'll probably have to change launching with wine (no need on windows!)- so maybe we can make the launcher configurable. But let's make a dedicated issue for that

zDEFz commented 5 months ago

Cool! So can we close this out?

That would be no good choice. So far, the experience had been inconsistent. Remember how much effort you put into this project People might deem it broken and never enjoy it, before they jump through the hoops...

We need to have better error / issue handling.

What system/ shell do you use though? This is still weird.

I do use zsh with zimfw defaults

CabalCrow commented 5 months ago

Blank list of games for me as well. I do not get any errors though.

dmadisetti commented 5 months ago

Can you try off zsh? I can't fix this if I can't replicate it

CabalCrow commented 5 months ago

I'm on zsh

dmadisetti commented 5 months ago

OK- good to have some commonality. Can you try bash on xterm?

CabalCrow commented 5 months ago

same result

chimps-ahoy commented 5 months ago

I'm on bash/dash (/bin/sh is dash but I used bash interactively, not sure what this program calls on), in st terminal and getting the same behaviour along with no error outputting when I try to make a log file.

dmadisetti commented 5 months ago

Cool, so windows verifiably breaks without logging because line character endings are weird. I'm wondering if whatever steamcmd versions you are using have a similar response. I just pushed something that adds logging around the problematic area.

If you could respond with your steamcmd version and an error log from "steam-tui 2> error.log" after building the source, that would go a long way.

CabalCrow commented 5 months ago

what is the command for building from source?

dmadisetti commented 5 months ago

cargo build https://doc.rust-lang.org/cargo/getting-started/installation.html

How are you currently getting steam-tui? arch?

CabalCrow commented 5 months ago

the AUR

CabalCrow commented 5 months ago

Seems to work when building from source - the problem is likely in the aur package.

dmadisetti commented 5 months ago

Ok cool. The AUR release commit was borked. I just repushed. Please try from AUR now.


This ended up being a pretty easy fix- so sorry about all the back and forth.

What do you think could have made the process go easier? Once I guessed it was an issue with AUR, it was pretty easy to find the problem

please give some feedback, because this was needlessly drawn out

CabalCrow commented 5 months ago

Having the standard copy pasta asking for package version & OS, would probably help in this case.

Ciflire commented 5 months ago

Same error here when building from flake

zDEFz commented 5 months ago

It appears that running steamcmd manually can help sometimes... But it's super annoying.

dmadisetti commented 5 months ago

So it's not AUR, and there are no debug logs? Even with the latest commit? I don't know what more I can do, because I cannot replicate

Ciflire commented 5 months ago

would love to provide debug logs if you tell me how to

dmadisetti commented 5 months ago

steam-tui 2> error.log

Ciflire commented 5 months ago

error.log I'm sorry i don't think that gonna be helpful

zDEFz commented 5 months ago

So it's not AUR, and there are no debug logs? Even with the latest commit? I don't know what more I can do, because I cannot replicate

I think what happens is that when steam is launched, it re-validates the user and invokes steamcmd and gets some kind of token.

When steam-tui is being ran, it doesn't first invoke steam to check if we are up-to-date and what not. My guesses:

When a update is available on steam

When the user tried on a bad connection or on VPN

And yes. the log is absolutely empty!

The following I have to do each time:

  1. steamcmd login ... for auth
  2. remove steam-tui caches
  3. steam-tui ... r for reload
  4. steam-tui will hang, need to press q/ctrl+c
  5. start steam-tui again and press r again, then exit
  6. start steam-tui yet another time
  7. game list appears with installed games
zDEFz commented 5 months ago

My suggestions:

  1. If never ran - then start steamcmd beforehand for initial auth.
  2. Download and install the last steam update programmatically (like steam itself would)
  3. Remove/Clear caches programmatically
  4. Revalidate login token/auth

Step 3 might prompt the user to login again, or its possible to re-use the cookie or something.

dmadisetti commented 5 months ago

The log actually looks very useful, steam version is embedded and we know that at least "info" was invoked. I'll take another look at it this weekend. If others can provide logs that would also be useful.

@zDEFz I will try that

monandszy commented 4 months ago

Issue still present