search

dmadison / LED-Segment-ASCII

Library of ASCII character representations using 7 segment, 14 segment, and 16 segment LED displays
MIT License
135 stars 21 forks source link

Update README.md #6

Closed reiyawea closed 5 years ago

reiyawea commented 5 years ago

Correct the 14-segment order

dmadison commented 5 years ago

See my comment in #5. Why do you believe the segment order is wrong? Can you please provide some references?

reiyawea commented 5 years ago

See my comment in #5. Why do you believe the segment order is wrong? Can you please provide some references?

See '0'(zero) of Fourteen-segment characters. Segment A to F, L and K should be turned on. The binary code of '0' is 0b000110000111111 in 14-Segment-ASCII_BIN.txt. According to the segment sequence "14 Segment: DP-L-M-N-K-J-H-G2-G1-F-E-D-C-B-A" shown in README, the binary code turns N, K, F to A on. Here N is incorrectly turned on instead of L.

In fact, I was doing a hobby project with a simliar alphanumeric LED display. Being too lazy to make the codes, I ported yours according to the segment definition in README, and later noticed that L and K are reversed. To obtain the consistency, I suggest changing the segment definition in README.

dmadison commented 5 years ago

Ah okay I see what you mean. So both the graphic "segment label" image and the LED code are accurate, but they don't match the text "segment order" in the README.

Thanks for explaining, that's definitely an oversight on my part. I'll merge this right away.