dmaes / ansible-role-vaultwarden

Builds, installs and configures Bitwarden_RS (https://github.com/dani-garcia/bitwarden_rs) (without Docker)
https://galaxy.ansible.com/dmaes/bitwardenrs
MIT License
9 stars 7 forks source link

bitwardenrs_domain not mentioned in documentation #1

Closed goetzk closed 4 years ago

goetzk commented 4 years ago

Hi,

bitwardenrs_domain is required in several places but not mentioned in the readme.

fatal: []: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'bitwardenrs_domain' is undefined\n\nThe error appears to be in '/Users/kgoetz/server-configuration-management/roles_git/dmaes.bitwardenrs/tasks/configure.yml': line 8, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Set domain\n  ^ here\n"}

This value needs to include protocol

May  1 22:47:02 credentials bitwarden_rs[50546]: #011DOMAIN variable needs to contain the protocol (http, https). Use 'http[s]://bw.example.com' instead of 'bw.example.com'

Would you accept a PR to update the readme?

dmaes commented 4 years ago

Discovered some more things to fix, so I'll do it all at once. Thanks anyway (would have been my first PR ever to merge tough)

goetzk commented 4 years ago

Thanks! -- Sent from my Android device with K-9 Mail. Please excuse my brevity.