search

dmaicher / doctrine-test-bundle

Symfony bundle to isolate your app's doctrine database tests and improve the test performance
MIT License
1.08k stars 60 forks source link

Fix a deprecation message related to return types #183

Closed javiereguiluz closed 2 years ago

javiereguiluz commented 2 years ago

This fixes the following deprecation:

  1x: Method "Doctrine\DBAL\Driver\Connection::quote()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "DAMA\DoctrineTestBundle\Doctrine\DBAL\AbstractStaticConnection" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command

which we found when upgrading Symfony Demo app to the upcoming Symfony 5.4. See https://github.com/symfony/demo/pull/1268#issuecomment-961933724

dmaicher commented 2 years ago

Thanks :+1: I think we need to adjust the php cs fixer config to allow keeping those @return mixed

Edit: I guess its this rule? https://github.com/dmaicher/doctrine-test-bundle/blob/master/.php-cs-fixer.php#L19

javiereguiluz commented 2 years ago

David, thanks for reviewing + merging ... and thanks for maintaining this nice bundle!