search

dmaicher / doctrine-test-bundle

Symfony bundle to isolate your app's doctrine database tests and improve the test performance
MIT License
1.08k stars 61 forks source link

Update bootstrap.php #294

Closed cooldude77 closed 5 months ago

cooldude77 commented 5 months ago

Proposing to change the bootstrap.php w.r.t. migrations part added

First we check if the migrations are upto the point if not we drop the database if it exists create migrate and continue to test cases

dmaicher commented 5 months ago

This bootstrap script is purely used for the test suite of this bundle itself and Its not meant to be used for anything else. So I don't see why we should apply such changes.

cooldude77 commented 5 months ago

True. It was incase you wanted to add migrations part to be included ever because I needed such a thing in my project where migrations were part of the scenario.

I will add a note to my own project.

Best regards, On Mon, 29 Apr, 2024, 14:19 David Maicher, @.***> wrote:

This bootstrap script is purely used for the test suite of this bundle itself and Its not meant to be used for anything else. So I don't see why we should apply such changes.

— Reply to this email directly, view it on GitHub https://github.com/dmaicher/doctrine-test-bundle/pull/294#issuecomment-2082183221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUKDYKFWGD47JPYRUV55FDY7YCSFAVCNFSM6AAAAABG53CHN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGE4DGMRSGE . You are receiving this because you authored the thread.Message ID: @.***>